netdev - Re: [PATCH net-next] net/mlx5e: Fix use-after-free in mlx5e_stats_grp_sw_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220314200825.GA28535@fastly.com>
Date:   Mon, 14 Mar 2022 13:08:26 -0700
From:   Joe Damato <jdamato@...tly.com>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH net-next] net/mlx5e: Fix use-after-free in
 mlx5e_stats_grp_sw_update_stats

On Fri, Mar 11, 2022 at 04:53:53PM -0800, Saeed Mahameed wrote:
> From: Saeed Mahameed <saeedm@...dia.com>
> 
> We need to sync page pool stats only for active channels. Reading ethtool
> stats on a down netdev or a netdev with modified number of channels will
> result in a user-after-free, trying to access page pools that are freed
> already.
> 
> BUG: KASAN: use-after-free in mlx5e_stats_grp_sw_update_stats+0x465/0xf80
> Read of size 8 at addr ffff888004835e40 by task ethtool/720
> 
> Fixes: cc10e84b2ec3 ("mlx5: add support for page_pool_get_stats")
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> Reported-by: Jakub Kicinski <kuba@...nel.org>

Err, sorry about that folks - my bad. Thanks for catching that Jakub and
sorry for the trouble Saeed.

LGTM.

Acked-by: Joe Damato <jdamato@...tly.com>