[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220314161156.073d9579@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Mon, 14 Mar 2022 16:11:56 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org,
jacob.e.keller@...el.com
Subject: Re: [PATCH net-next 00/25][pull request] 100GbE Intel Wired LAN
Driver Updates 2022-03-14
On Mon, 14 Mar 2022 11:09:51 -0700 Tony Nguyen wrote:
> The ice_virtchnl_pf.c file has become a single place for a lot of
> virtualization functionality. This includes most of the virtchnl message
> handling, integration with kernel hooks like the .ndo operations, reset
> logic, and more.
>
> We are planning in the future to implement and support Scalable IOV in the
> ice driver. To do this, much (but not all) of the code in ice_virtchnl_pf.c
> will want to be reused.
>
> Rather than dump all of the Scalable IOV implementation into
> ice_virtchnl_pf.c it makes sense to house it in a separate file. But that
> still leaves all of the Single Root IOV code littered among more generic
> logic.
>
> This series reorganizes code to make the non-implementation specific bits
> into new files with the following general guidelines:
>
> * ice_vf_lib.[ch]
>
> Basic VF structures and accessors. This is where scheme-independent
> code will reside.
>
> * ice_virtchnl.[ch]
>
> Virtchnl message handling. This is where the bulk of the logic for
> processing messages from VFs using the virtchnl messaging scheme will
> reside. This is separated from ice_vf_lib.c because it is distinct
> and has a bulk of the processing code.
>
> * ice_sriov.[ch]
>
> Single Root IOV implementation, including initialization and the
> routines for interacting with SR-IOV based netdev operations.
>
> * (future) ice_siov.[ch]
>
> Scalable IOV implementation.
>
> The goal is to make it easier to re-use parts of the virtualization logic
> while separating concerns such as Single Root specific implementation
> details.
>
> In addition, this series has several minor cleanups and refactors we've
> accumulated during this development cycle which help prepare the ice driver
> for the Scalable IOV implementation.
Why is there 25 patches in this series? The limit is 15. If you need to
show a longer trajectory of the work you can post a link to a branch
with all the patches so that interested parties can take a look.
We apply patches rather promptly, please return us a favor and obey
the limit.
Powered by blists - more mailing lists