netdev - Re: [PATCH net-next 6/6] devlink: pass devlink_port to port_split / port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjBPCAPAe+Z9r25i@shredder>
Date:   Tue, 15 Mar 2022 10:32:08 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jiri@...dia.com,
        idosch@...dia.com, petrm@...dia.com, simon.horman@...igine.com,
        louis.peens@...igine.com, leon@...nel.org
Subject: Re: [PATCH net-next 6/6] devlink: pass devlink_port to port_split /
 port_unsplit callbacks

On Mon, Mar 14, 2022 at 11:00:09PM -0700, Jakub Kicinski wrote:
> Now that devlink ports are protected by the instance lock
> it seems natural to pass devlink_port as an argument to
> the port_split / port_unsplit callbacks.
> 
> This should save the drivers from doing a lookup.
> 
> In theory drivers may have supported unsplitting ports
> which were not registered prior to this change.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Ido Schimmel <idosch@...dia.com>
Tested-by: Ido Schimmel <idosch@...dia.com>