netdev - RE: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary HBH/jumbo header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW5PR15MB51212AD0A46066FD465C4800BD109@MW5PR15MB5121.namprd15.prod.outlook.com>
Date:   Tue, 15 Mar 2022 17:35:25 +0000
From:   Alexander Duyck <alexanderduyck@...com>
To:     Eric Dumazet <edumazet@...gle.com>
CC:     Alexander H Duyck <alexander.duyck@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, Coco Li <lixiaoyan@...gle.com>
Subject: RE: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary HBH/jumbo
 header

> -----Original Message-----
> From: Eric Dumazet <edumazet@...gle.com>
> Sent: Tuesday, March 15, 2022 9:11 AM
> To: Alexander Duyck <alexanderduyck@...com>
> Cc: Alexander H Duyck <alexander.duyck@...il.com>; Eric Dumazet
> <eric.dumazet@...il.com>; David S . Miller <davem@...emloft.net>;
> Jakub Kicinski <kuba@...nel.org>; netdev <netdev@...r.kernel.org>; Coco
> Li <lixiaoyan@...gle.com>
> Subject: Re: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary
> HBH/jumbo header
> 
> On Tue, Mar 15, 2022 at 9:04 AM Alexander Duyck
> <alexanderduyck@...com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Eric Dumazet <edumazet@...gle.com>
> > > Sent: Tuesday, March 15, 2022 9:02 AM
> > > To: Alexander H Duyck <alexander.duyck@...il.com>
> > > Cc: Eric Dumazet <eric.dumazet@...il.com>; David S . Miller
> > > <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; netdev
> > > <netdev@...r.kernel.org>; Alexander Duyck
> <alexanderduyck@...com>;
> > > Coco Li <lixiaoyan@...gle.com>
> > > Subject: Re: [PATCH v4 net-next 06/14] ipv6/gro: insert temporary
> > > HBH/jumbo header
> > >
> > > On Fri, Mar 11, 2022 at 8:24 AM Alexander H Duyck
> > > <alexander.duyck@...il.com> wrote:
> > > >
> > > > On Wed, 2022-03-09 at 21:46 -0800, Eric Dumazet wrote:
> > > > > From: Eric Dumazet <edumazet@...gle.com>
> > > > >
> > > > > Following patch will add GRO_IPV6_MAX_SIZE, allowing gro to
> > > > > build BIG TCP ipv6 packets (bigger than 64K).
> > > > >
> > > >
> > > > This looks like it belongs in the next patch, not this one. This
> > > > patch is adding the HBH header.
> > >
> > > What do you mean by "it belongs" ?
> > >
> > > Do you want me to squash the patches, or remove the first sentence ?
> > >
> > > I am confused.
> >
> > It is about the sentence. Your next patch essentially has that as the title and
> actually does add GRO_IPV6_MAX_SIZE. I wasn't sure if you reordered the
> patches or split them. However as I recall I didn't see anything in this patch
> that added GRO_IPV6_MAX_SIZE.
> 
> 
> I used "Following patch will", meaning the patch following _this_ one, sorry if
> this is confusing.
> 
> I would have used  "This patch is ..." if I wanted to describe what this patch is
> doing.
> 
> Patches were not reordered, and have two different authors.

Yeah, the problem is I read "Following patch" as in the "The patch below". I would probably drop the line since it doesn't add much to the patch itself.