netdev - Re: [PATCH bpf v3] bpf: Support dual-stack sockets in bpf_tcp_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQKasn7ZDM8FYu67FM8FzMyQPqyP=1gYvqaYQBfMkM3pbA@mail.gmail.com>
Date:   Tue, 15 Mar 2022 14:26:07 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Maxim Mikityanskiy <maximmi@...dia.com>
Cc:     "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Jakub Sitnicki <jakub@...udflare.com>
Subject: Re: [PATCH bpf v3] bpf: Support dual-stack sockets in bpf_tcp_check_syncookie

On Mon, Mar 14, 2022 at 10:49 AM Maxim Mikityanskiy <maximmi@...dia.com> wrote:
>
> > -----Original Message-----
> > From: Alexei Starovoitov <alexei.starovoitov@...il.com>
> >
> > On Fri, Mar 11, 2022 at 8:36 AM Maxim Mikityanskiy <maximmi@...dia.com>
> > wrote:
> > >
> > > This patch was submitted more than two weeks ago, and there were no new
> > > comments. Can it be accepted?
> >
> > The patch wasn't acked by anyone.
> > Please solicit reviews for your changes in time.
>
> Could you elaborate? I sent the patch to the mailing list and CCed the
> relevant people. That worked for v1 and v2, I received comments,
> addressed them and sent a v3. What extra steps should I have done to
> "solicit reviews"? What shall I do now?

cloudflare folks are original authors of this helper and
de-facto owners of this piece of code.
They need to ack it.
So you have to rebase, resubmit and solicit reviews.