netdev - Re: [PATCH net-next 2/3] net/mlx5e: MPLSoUDP decap, use vlan push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220314220244.5e8e3cb7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 14 Mar 2022 22:02:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Roi Dayan <roid@...dia.com>
Cc:     <netdev@...r.kernel.org>, Maor Dickman <maord@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Jamal Hadi Salim" <jhs@...atatu.com>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 2/3] net/mlx5e: MPLSoUDP decap, use vlan
 push_eth instead of pedit

On Wed, 9 Mar 2022 15:02:55 +0200 Roi Dayan wrote:
> +	case FLOW_ACTION_VLAN_PUSH_ETH:
> +		if (!flow_flag_test(parse_state->flow, L3_TO_L2_DECAP))
> +			return -EOPNOTSUPP;
> +		parse_state->eth_push = true;
> +		memcpy(attr->eth.h_dest, act->vlan_push_eth_dst, ETH_ALEN);
> +		memcpy(attr->eth.h_source, act->vlan_push_eth_src, ETH_ALEN);
> +		break;

How does the device know the proto? I kind of expected this code will
require some form of a match on proto.