netdev - Re: [PATCH] Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Mar 2022 16:33:36 +0100
From:   Niels Dossche <dossche.niels@...il.com>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     netdev@...r.kernel.org, Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>
Subject: Re: [PATCH] Bluetooth: call hci_le_conn_failed with hdev lock in
 hci_le_conn_failed

On 16/03/2022 16:32, Marcel Holtmann wrote:
> Hi Niels,
> 
>> hci_le_conn_failed function's documentation says that the caller must
>> hold hdev->lock. The only callsite that does not hold that lock is
>> hci_le_conn_failed. The other 3 callsites hold the hdev->lock very
>> locally. The solution is to hold the lock during the call to
>> hci_le_conn_failed.
>>
>> Fixes: 3c857757ef6e ("Bluetooth: Add directed advertising support through connect()")
>> Signed-off-by: Niels Dossche <dossche.niels@...il.com>
>> ---
>> net/bluetooth/hci_conn.c | 2 ++
>> 1 file changed, 2 insertions(+)
> 
> please send net/bluetooth/ to linux-bluetooth mailing list.
> 
> Regards
> 
> Marcel
> 

Hi Marcel
My bad, I'll resend it to there, I have copied the wrong mail address.
Regards
Niels