netdev - Re: [PATCH net-next 3/6] eth: nfp: replace driver's "pf" lock with devlink instance lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220316094527.16377adc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 16 Mar 2022 09:45:27 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, jiri@...dia.com,
        idosch@...dia.com, petrm@...dia.com, simon.horman@...igine.com,
        louis.peens@...igine.com
Subject: Re: [PATCH net-next 3/6] eth: nfp: replace driver's "pf" lock with
 devlink instance lock

On Wed, 16 Mar 2022 10:34:31 +0200 Leon Romanovsky wrote:
> > -#define nfp_app_is_locked(app)	lockdep_is_held(&(app)->pf->lock)
> > +static inline bool nfp_app_is_locked(struct nfp_app *app)
> > +{
> > +	return devl_lock_is_held(priv_to_devlink(app->pf));
> > +}  
> 
> Does it compile if you set CONFIG_LOCKDEP=n?

Yes, it's exactly the same as lockdep_is_held(). PTAL at lockdep.h, 
the extern int lockdep_is_held(const void *); is under LOCKDEP=n.
There is no definition for it.