netdev - Re: [PATCH net 3/3] iavf: Fix double free in iavf_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8499d14a-ea8d-a8a0-be46-c2ca5e050ddc@intel.com>
Date:   Wed, 16 Mar 2022 11:46:54 -0700
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <pabeni@...hat.com>,
        Przemyslaw Patynowski <przemyslawx.patynowski@...el.com>,
        <netdev@...r.kernel.org>, <sassmann@...hat.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        "Mateusz Palczewski" <mateusz.palczewski@...el.com>,
        Konrad Jankowski <konrad0.jankowski@...el.com>
Subject: Re: [PATCH net 3/3] iavf: Fix double free in iavf_reset_task


On 3/15/2022 8:30 PM, Jakub Kicinski wrote:
> On Tue, 15 Mar 2022 14:12:25 -0700 Tony Nguyen wrote:
>> Fix double free possibility in iavf_disable_vf, as crit_lock is
>> freed in caller, iavf_reset_task. Add kernel-doc for iavf_disable_vf.
>> Remove mutex_unlock in iavf_disable_vf.
>> Without this patch there is double free scenario, when calling
>> iavf_reset_task.
> s/free/unlock/ or s/free/release/
Will fix.