netdev - RE: [EXT] bnx2x: How to log the firmware version? (was: [RFC net] bnx2x: fix built-in kernel driver load failure)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Mar 2022 22:03:18 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
CC:     Donald Buczek <buczek@...gen.mpg.de>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        "it+netdev@...gen.mpg.de" <it+netdev@...gen.mpg.de>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>
Subject: RE: [EXT] bnx2x: How to log the firmware version? (was: [RFC net]
 bnx2x: fix built-in kernel driver load failure)

> -----Original Message-----
> From: Paul Menzel <pmenzel@...gen.mpg.de>
> Sent: Thursday, March 17, 2022 2:06 AM
> To: Manish Chopra <manishc@...vell.com>
> Cc: Donald Buczek <buczek@...gen.mpg.de>; Jakub Kicinski
> <kuba@...nel.org>; netdev@...r.kernel.org; Ariel Elior
> <aelior@...vell.com>; it+netdev@...gen.mpg.de;
> regressions@...ts.linux.dev
> Subject: [EXT] bnx2x: How to log the firmware version? (was: [RFC net] bnx2x:
> fix built-in kernel driver load failure)
> 
> External Email
> 
> ----------------------------------------------------------------------
> Dear Manish,
> 
> 
> Thank you for your answer.
> 
> Am 16.03.22 um 19:25 schrieb Manish Chopra:
> 
> >> -----Original Message-----
> >> From: Paul Menzel <pmenzel@...gen.mpg.de>
> 
> […]
> 
> >> Hmm, with `CONFIG_BNX2X=y` and `bnx2x.debug=0x0100000`, bringing up
> >> net05 (.1) and then net04 (.0), I only see:
> >>
> >>       [ 3333.883697] bnx2x: [bnx2x_compare_fw_ver:2378(net04)]loaded
> >> fw f0d07 major 7 minor d rev f eng 0
> >
> > I think this print is not good probably  (that's why it is default
> > disabled), it’s not really the firmware driver is supposed to work
> > with (it is something which was already loaded by any other PF
> > somewhere or some residue from earlier loads),
> Still interesting, when handling firmware files, and trying to wrap ones head
> around the different versions flying around.
> 
> > driver is always going to work with the firmware it gets from
> > request_firmware(). I suggest you to enable below prints to know about
> > which FW driver is going to work with. Perhaps, I will enable below
> > default.
> >
> >          BNX2X_DEV_INFO("Loading %s\n", fw_file_name);
> >
> >          rc = request_firmware(&bp->firmware, fw_file_name, &bp->pdev-
> >dev);
> >          if (rc) {
> >                  BNX2X_DEV_INFO("Trying to load older fw %s\n",
> > fw_file_name_v15);
> 
> Indeed, after figuring out to enable `BNX2X_DEV_INFO()` by the probe flag 0x2
> – so either `bnx2x.debug=0x2` or `ethtool -s net04 msglvl 0x2`, Linux logs:
> 
>      $ dmesg --level=info | grep bnx2x | tail -8
>      [  242.987091] bnx2x 0000:45:00.1: fw_seq 0x0000003b
>      [  242.994144] bnx2x 0000:45:00.1: drv_pulse 0x6404
>      [  243.038239] bnx2x 0000:45:00.1: Loading bnx2x/bnx2x-e1h-7.13.21.0.fw
>      [  243.356284] bnx2x 0000:45:00.1 net05: using MSI-X  IRQs: sp 57 fp[0] 59
> ... fp[7] 66
>      [  571.774061] bnx2x 0000:45:00.0: fw_seq 0x0000003b
>      [  571.781069] bnx2x 0000:45:00.0: drv_pulse 0x2149
>      [  571.799963] bnx2x 0000:45:00.0: Loading bnx2x/bnx2x-e1h-7.13.21.0.fw
>      [  571.811657] bnx2x 0000:45:00.0 net04: using MSI-X  IRQs: sp 46 fp[0] 48
> ... fp[7] 55
>      $ dmesg --level=err | grep bnx2x
>      [  571.979621] bnx2x 0000:45:00.0 net04: Warning: Unqualified SFP+
> module detected, Port 0 from Intel Corp       part number AFBR-703SDZ-IN2
> 
> Maybe the firmware version could be added to the line with the MSI-X and
> IRQ info. Maybe also the old version on the device, which `ethtool -i net04`
> shows.
> 
>      $ ethtool -i net04 | grep firmware
>      firmware-version: 7.8.16 bc 6.2.26 phy aa0.406
> 
> No idea, why ethtool does not show the loaded firmware.

thanks Paul for your questions/suggestions and specially verification of the fix.
I would prefer to enable/adjust or add any new logs in a separate commit (just not to add many things in same commit)
The version you see in ethtool is actually a different firmware called as management firmware (MFW) running on the device.
May be we can check the feasibility of reporting both the FW versions (MFW and FW file version on the host) in ethtool.
Or perhaps MFW in system log and FW file version in ethtool.

Thanks.