netdev - RE: [Intel-wired-lan] [PATCH] igb: zero hwtstamp by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB3367BC9F34175A1D52EB68D4FC119@BYAPR11MB3367.namprd11.prod.outlook.com>
Date:   Wed, 16 Mar 2022 06:14:24 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     "trix@...hat.com" <trix@...hat.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "nathan@...nel.org" <nathan@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] igb: zero hwtstamp by default



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> trix@...hat.com
> Sent: Sunday, March 13, 2022 8:32 PM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net; kuba@...nel.org;
> nathan@...nel.org; ndesaulniers@...gle.com
> Cc: netdev@...r.kernel.org; llvm@...ts.linux.dev; intel-wired-
> lan@...ts.osuosl.org; linux-kernel@...r.kernel.org; Tom Rix
> <trix@...hat.com>
> Subject: [Intel-wired-lan] [PATCH] igb: zero hwtstamp by default
> 
> From: Tom Rix <trix@...hat.com>
> 
> Clang static analysis reports this representative issue
> igb_ptp.c:997:3: warning: The left operand of '+' is a
>   garbage value
>   ktime_add_ns(shhwtstamps.hwtstamp, adjust);
>   ^            ~~~~~~~~~~~~~~~~~~~~
> 
> shhwtstamps.hwtstamp is set by a call to igb_ptp_systim_to_hwtstamp().  In
> the switch-statement for the hw type, the hwtstamp is zeroed for matches
> but not the default case.  Move the memset out of switch-statement.  This
> degarbages the default case and reduces the size.
> 
> Some whitespace cleanup of empty lines
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ptp.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at Intel)