netdev - Re: bnx2x: ppc64le: Unable to set message level greater than 0x7fff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220315183529.255f2795@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 15 Mar 2022 18:35:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Paul Menzel <pmenzel@...gen.mpg.de>,
        Michal Kubecek <mkubecek@...e.cz>
Cc:     Ariel Elior <aelior@...vell.com>,
        Sudarsana Kalluru <skalluru@...vell.com>,
        Manish Chopra <manishc@...vell.com>, netdev@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: bnx2x: ppc64le: Unable to set message level greater than 0x7fff

On Tue, 15 Mar 2022 22:58:57 +0100 Paul Menzel wrote:
> On the POWER8 server IBM S822LC (ppc64le), I am unable to set the 
> message level for the network device to 0x0100000 but it fails.
> 
>      $ sudo ethtool -s enP1p1s0f2 msglvl 0x0100000
>      netlink error: cannot modify bits past kernel bitset size (offset 56)
>      netlink error: Invalid argument
> 
> Below is more information. 0x7fff is the largest value I am able to set.
> 
> ```
> $ sudo ethtool -i enP1p1s0f2
> driver: bnx2x
> version: 5.17.0-rc7+
> firmware-version: bc 7.10.4
> expansion-rom-version:
> bus-info: 0001:01:00.2
> supports-statistics: yes
> supports-test: yes
> supports-eeprom-access: yes
> supports-register-dump: yes
> supports-priv-flags: yes
> $ sudo ethtool -s enP1p1s0f2 msglvl 0x7fff
> $ sudo ethtool enP1p1s0f2
> Settings for enP1p1s0f2:
>          Supported ports: [ TP ]
>          Supported link modes:   10baseT/Half 10baseT/Full
>                                  100baseT/Half 100baseT/Full
>                                  1000baseT/Full
>          Supported pause frame use: Symmetric Receive-only
>          Supports auto-negotiation: Yes
>          Supported FEC modes: Not reported
>          Advertised link modes:  10baseT/Half 10baseT/Full
>                                  100baseT/Half 100baseT/Full
>                                  1000baseT/Full
>          Advertised pause frame use: Symmetric Receive-only
>          Advertised auto-negotiation: Yes
>          Advertised FEC modes: Not reported
>          Speed: Unknown!
>          Duplex: Unknown! (255)
>          Auto-negotiation: on
>          Port: Twisted Pair
>          PHYAD: 17
>          Transceiver: internal
>          MDI-X: Unknown
>          Supports Wake-on: g
>          Wake-on: d
>          Current message level: 0x00007fff (32767)
>                                 drv probe link timer ifdown ifup rx_err 
> tx_err tx_queued intr tx_done rx_status pktdata hw wol
>          Link detected: no
> $ sudo ethtool -s enP1p1s0f2 msglvl 0x8000
> netlink error: cannot modify bits past kernel bitset size (offset 56)
> netlink error: Invalid argument
> ```

The new ethtool-over-netlink API limits the msg levels to the ones
officially defined by the kernel (NETIF_MSG_CLASS_COUNT).

CC: Michal