netdev - Re: [PATCH] net: axiemac: use a phandle to reference pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABgGipV6ezNqtaf_aP1fYcwHVOKJQS9oNahu48L1Q6-+cWrwLw@mail.gmail.com>
Date:   Thu, 17 Mar 2022 17:10:40 +0800
From:   Andy Chiu <andy.chiu@...ive.com>
To:     Robert Hancock <robert.hancock@...ian.com>
Cc:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "greentime.hu@...ive.com" <greentime.hu@...ive.com>
Subject: Re: [PATCH] net: axiemac: use a phandle to reference pcs_phy

Thanks for the kind help and suggestions.

I will submit the v2 patchset with an updated flow that supports both
cases, and include a binding document. And use the correct mail
address.

Regards,
Andy

On Thu, Mar 17, 2022 at 5:15 AM Robert Hancock
<robert.hancock@...ian.com> wrote:
>
> Re: https://lore.kernel.org/all/20220316075953.61398-1-andy.chiu@sifive.com/
> (looks like I was CCed with the wrong email):
>
> I think we likely need something similar to this for the use case (I assume)
> you have, where there's an external SGMII PHY as well as the internal PCS/PMA
> PHY which both need to be configured. However, we (and possibly others) already
> have some cases where the core is connected to an SFP cage, phy-handle points
> to the internal PCS/PMA PHY, and the external PHY - if one exists at all - is
> not in the device tree because it would be on an SFP module.
>
> Also, as Jakub mentioned, it looks like other drivers like dpaa2 use pcs-handle
> for this.
>
> Possibly something like: in the 1000Base-X or SGMII modes, if pcs-handle is
> set, then use that as the PCS node, otherwise fall back to assuming phy-handle
> points to the PCS. It should not require that both are present, since even in
> the pure SGMII case, the PHY could still be supplied by an SFP module
> downstream.
>
> --
> Robert Hancock
> Senior Hardware Designer, Calian Advanced Technologies
> www.calian.com