netdev - Re: [PATCH AUTOSEL 5.10 19/20] bnx2: Fix an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220317112318.GC2237@amd>
Date:   Thu, 17 Mar 2022 12:23:18 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>, Greg KH <greg@...ah.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "David S . Miller" <davem@...emloft.net>, rmody@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, kuba@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 19/20] bnx2: Fix an error message

Hi!

> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> [ Upstream commit 8ccffe9ac3239e549beaa0a9d5e1a1eac94e866c ]
> 
> Fix an error message and report the correct failing function.

This patch is not really fixing an important bug, it is just tweaking
an error message. I'm not sure why it is being queued for stable. I
believe AUTOSEL process should be more careful.

Second, at least for 5.10 and older, it is not _fixing_ bug, it is
_adding_ one, as old message is correct there.

Please drop.
								Pavel

> +++ b/drivers/net/ethernet/broadcom/bnx2.c
> @@ -8229,7 +8229,7 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
>  		rc = pci_set_consistent_dma_mask(pdev, persist_dma_mask);
>  		if (rc) {
>  			dev_err(&pdev->dev,
> -				"pci_set_consistent_dma_mask failed, aborting\n");
> +				"dma_set_coherent_mask failed, aborting\n");
>  			goto err_out_unmap;
>  		}
>  	} else if ((rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) != 0) {

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)