netdev - Re: [PATCH net-next 1/5] bnxt: use the devlink instance lock to protect sriov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHHeUGVA2UodrRCYOwy-yinjyhU8geepmZKKwtcu75zO+tyxfA@mail.gmail.com>
Date:   Fri, 18 Mar 2022 00:54:31 +0530
From:   Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org,
        Jiří Pírko <jiri@...nulli.us>,
        leonro@...dia.com, saeedm@...dia.com, idosch@...sch.org,
        Michael Chan <michael.chan@...adcom.com>,
        simon.horman@...igine.com,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
Subject: Re: [PATCH net-next 1/5] bnxt: use the devlink instance lock to
 protect sriov

On Thu, Mar 17, 2022 at 11:50 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 17 Mar 2022 23:15:33 +0530 Sriharsha Basavapatna wrote:
> > The changes look good to me overall. But I have a few concerns. This
> > change introduces a lock that is held across modules and if there's
> > any upcall from the driver into devlink that might potentially acquire
> > the same lock, then it could result in a deadlock. I'm not familiar
> > with the internals of devlink, but just want to make sure this point
> > is considered. Also, the driver needs to be aware of this lock and use
> > it in new code paths within the driver to synchronize with switchdev
> > operations. This may not be so obvious when compared to a driver
> > private lock.
>
> That's true, that's why we're adding the new "unlocked" devl_* API.
> I'm switching the drivers accordingly, I didn't see any upcalls in
> the relevant parts in bnxt, LMK if I missed something!

There's no upcall currently at least in switchdev related code in bnxt.

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4236 bytes)