netdev - Re: [PATCH bpf-next v3 0/4] Fixes for sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220318010148.6dju4zlx2omhmje4@kafai-mbp.dhcp.thefacebook.com>
Date:   Thu, 17 Mar 2022 18:01:48 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        kernel-team@...udflare.com, Ilya Leoshkevich <iii@...ux.ibm.com>
Subject: Re: [PATCH bpf-next v3 0/4] Fixes for sock_fields selftests

On Thu, Mar 17, 2022 at 12:39:16PM +0100, Jakub Sitnicki wrote:
> I think we have reached a consensus [1] on how the test for the 4-byte load from
> bpf_sock->dst_port and bpf_sk_lookup->remote_port should look, so here goes v3.
> 
> I will submit a separate set of patches for bpf_sk_lookup->remote_port tests.
> 
> 
> This series has been tested on x86_64 and s390 on top of recent bpf-next -
> ad13baf45691 ("selftests/bpf: Test subprog jit when toggle bpf_jit_harden
> repeatedly").
> 
> [1] https://lore.kernel.org/bpf/87k0cwxkzs.fsf@cloudflare.com/
> 
> v2 -> v3:
> - Split what was previously patch 2 which was doing two things
> - Use BPF_TCP_* constants (Martin)
> - Treat the result of 4-byte load from dst_port as a 16-bit value (Martin)
> - Typo fixup and some rewording in patch 4 description
Thanks for your work on this and reached a resolution with the remote_port !

Acked-by: Martin KaFai Lau <kafai@...com>