netdev - Re: [PATCH bpf] selftests/bpf: exit with error code if test failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a8e0d47-5498-2175-57ca-374ee9985b1f@iogearbox.net>
Date:   Fri, 18 Mar 2022 16:05:31 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc:     Sean Young <sean@...s.org>, Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf] selftests/bpf: exit with error code if test failed

On 3/17/22 8:18 AM, Hangbin Liu wrote:
> The test_lirc_mode2.sh test exit with 0 even test failed. Fix it by
> exiting with an error code.
> 
> Fixes: 6bdd533cee9a ("bpf: add selftest for lirc_mode2 type program")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   tools/testing/selftests/bpf/test_lirc_mode2.sh | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh
> index ec4e15948e40..420dc86362f5 100755
> --- a/tools/testing/selftests/bpf/test_lirc_mode2.sh
> +++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh
> @@ -36,3 +36,5 @@ then
>   		echo -e ${GREEN}"PASS: $TYPE"${NC}
>   	fi
>   fi
> +
> +exit $ret

nit: Shouldn't this also exit with error if no test_lirc_mode2_user was run?