netdev - Re: [PATCH] vdpa: Update man page with added support to configure max vq pair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0d3d255-ffb8-f830-f64a-b4de32d871a5@oracle.com>
Date:   Fri, 18 Mar 2022 09:27:43 -0700
From:   Si-Wei Liu <si-wei.liu@...cle.com>
To:     Eli Cohen <elic@...dia.com>, dsahern@...nel.org,
        stephen@...workplumber.org, netdev@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, jasowang@...hat.com
Cc:     mst@...hat.com, lulu@...hat.com, parav@...dia.com
Subject: Re: [PATCH] vdpa: Update man page with added support to configure max
 vq pair



On 3/15/2022 6:13 AM, Eli Cohen wrote:
> Update man page to include information how to configure the max
> virtqueue pairs for a vdpa device when creating one.
>
> Signed-off-by: Eli Cohen <elic@...dia.com>
> ---
>   man/man8/vdpa-dev.8 | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/man/man8/vdpa-dev.8 b/man/man8/vdpa-dev.8
> index aa21ae3acbd8..432867c65182 100644
> --- a/man/man8/vdpa-dev.8
> +++ b/man/man8/vdpa-dev.8
> @@ -33,6 +33,7 @@ vdpa-dev \- vdpa device configuration
>   .I MGMTDEV
>   .RI "[ mac " MACADDR " ]"
>   .RI "[ mtu " MTU " ]"
> +.RI "[ max_vqp " MAX_VQ_PAIRS " ]"
>   


Here it introduces the max_vqp option to the SYNOPSIS. I would be nice 
to describe what it means and which device type is applicable in the 
below section:

> .PP
> .BI mac " MACADDR"
> - specifies the mac address for the new vdpa device.
> This is applicable only for the network type of vdpa device. This is optional.
>
> .BI mtu " MTU"
> - specifies the mtu for the new vdpa device.
> This is applicable only for the network type of vdpa device. This is optional.
>

Otherwise looks good to me.

Reviewed-by: Si-Wei Liu <si-wei.liu@...cle.com>

Thanks,
-Siwei
>   .ti -8
>   .B vdpa dev del
> @@ -119,6 +120,11 @@ vdpa dev add name foo mgmtdev vdpa_sim_net mac 00:11:22:33:44:55 mtu 9000
>   Add the vdpa device named foo on the management device vdpa_sim_net with mac address of 00:11:22:33:44:55 and mtu of 9000 bytes.
>   .RE
>   .PP
> +vdpa dev add name foo mgmtdev auxiliary/mlx5_core.sf.1 mac 00:11:22:33:44:55 max_vqp 8
> +.RS 4
> +Add the vdpa device named foo on the management device auxiliary/mlx5_core.sf.1 with mac address of 00:11:22:33:44:55 and max 8 virtqueue pairs
> +.RE
> +.PP
>   vdpa dev del foo
>   .RS 4
>   Delete the vdpa device named foo which was previously created.