netdev - Re: [PATCH net-next 10/10] nfp: nfdk: implement xdp tx path for NFDK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220318105645.3ee1cb6c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 18 Mar 2022 10:56:45 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        oss-drivers@...igine.com
Subject: Re: [PATCH net-next 10/10] nfp: nfdk: implement xdp tx path for
 NFDK

On Fri, 18 Mar 2022 11:13:02 +0100 Simon Horman wrote:
> From: Yinjun Zhang <yinjun.zhang@...igine.com>
> 
> Due to the different definition of txbuf in NFDK comparing to NFD3,
> there're no pre-allocated txbufs for xdp use in NFDK's implementation,
> we just use the existed rxbuf and recycle it when xdp tx is completed.
> 
> For each packet to transmit in xdp path, we cannot use more than
> `NFDK_TX_DESC_PER_SIMPLE_PKT` txbufs, one is to stash virtual address,
> and another is for dma address, so currently the amount of transmitted
> bytes is not accumulated. Also we borrow the last bit of virtual addr
> to indicate a new transmitted packet due to address's alignment
> attribution.
> 
> Signed-off-by: Yinjun Zhang <yinjun.zhang@...igine.com>
> Signed-off-by: Fei Qin <fei.qin@...igine.com>
> Signed-off-by: Simon Horman <simon.horman@...igine.com>

Breaks 32 bit :(