netdev - Re: mv88e6xxx broken on 6176 with "Disentangle STU from VTU"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a6dnjce6.fsf@waldekranz.com>
Date:   Fri, 18 Mar 2022 20:20:33 +0100
From:   Tobias Waldekranz <tobias@...dekranz.com>
To:     Marek Behún <kabel@...nel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: mv88e6xxx broken on 6176 with "Disentangle STU from VTU"

On Fri, Mar 18, 2022 at 18:28, Marek Behún <kabel@...nel.org> wrote:
> Hello Tobias,
>
> mv88e6xxx fails to probe in net-next on Turris Omnia, bisect leads to
> commit
>   49c98c1dc7d9 ("net: dsa: mv88e6xxx: Disentangle STU from VTU")

Oh wow, really sorry about that! I have it reproduced, and I understand
the issue.

> Trace:
>   mv88e6xxx_setup
>     mv88e6xxx_setup_port
>       mv88e6xxx_port_vlan_join(MV88E6XXX_VID_STANDALONE) OK
>       mv88e6xxx_port_vlan_join(MV88E6XXX_VID_BRIDGED) -EOPNOTSUPP
>

Thanks, that make it easy to find. There is a mismatch between what the
family-info struct says and what the chip-specific ops struct supports.

I'll try to send a fix ASAP.