netdev - Re: [PATCH bpf-next] net: xdp: introduce XDP_PACKET_HEADROOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220318123323.75973f84@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 18 Mar 2022 12:33:23 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net,
        ast@...nel.org, daniel@...earbox.net, brouer@...hat.com,
        pabeni@...hat.com, toke@...hat.com, lorenzo.bianconi@...hat.com,
        andrii@...nel.org, nbd@....name
Subject: Re: [PATCH bpf-next] net: xdp: introduce XDP_PACKET_HEADROOM_MIN
 for veth and generic-xdp

On Fri, 18 Mar 2022 20:19:29 +0100 Lorenzo Bianconi wrote:
> diff --git a/net/core/dev.c b/net/core/dev.c
> index ba69ddf85af6..92d560e648ab 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -4737,7 +4737,7 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb,
>  	 * native XDP provides, thus we need to do it here as well.
>  	 */
>  	if (skb_cloned(skb) || skb_is_nonlinear(skb) ||
> -	    skb_headroom(skb) < XDP_PACKET_HEADROOM) {
> +	    skb_headroom(skb) < XDP_PACKET_HEADROOM_MIN) {
>  		int hroom = XDP_PACKET_HEADROOM - skb_headroom(skb);
>  		int troom = skb->tail + skb->data_len - skb->end;
>  

IIUC the initial purpose of SKB mode was to be able to test or
experiment with XDP "until drivers add support". If that's still
the case the semantics of XDP SKB should be as close to ideal
XDP implementation as possible.

We had a knob for specifying needed headroom, is that thing not 
working / not a potentially cleaner direction?