netdev - Re: [PATCH net-next] net: dsa: felix: allow PHY_INTERFACE_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78658409-40f6-227e-78e7-92364cffabd2@gmail.com>
Date:   Fri, 18 Mar 2022 14:22:44 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com,
        Colin Foster <colin.foster@...advantage.com>
Subject: Re: [PATCH net-next] net: dsa: felix: allow
 PHY_INTERFACE_MODE_INTERNAL on port 5

On 3/18/22 12:58 PM, Vladimir Oltean wrote:
> The Felix switch has 6 ports, 2 of which are internal.
> Due to some misunderstanding, my initial suggestion for
> vsc9959_port_modes[]:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220129220221.2823127-10-colin.foster@in-advantage.com/#24718277
> 
> got translated by Colin into a 5-port array, leading to an all-zero port
> mode mask for port 5.
> 
> Fixes: acf242fc739e ("net: dsa: felix: remove prevalidate_phy_mode interface")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian