netdev - Re: [PATCH -next] wlwifi: mei: Fix build error without CFG80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee4cc974-1cfc-f9ba-5e23-f429eb5d311d@huawei.com>
Date:   Fri, 18 Mar 2022 12:03:26 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <luciano.coelho@...el.com>, <kvalo@...nel.org>,
        <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <ayala.beker@...el.com>, <emmanuel.grumbach@...el.com>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] wlwifi: mei: Fix build error without CFG80211

On 2022/3/18 11:01, YueHaibing wrote:
> If CFG80211 is n and IWLMEI is y,  building fails:
> 
> drivers/net/wireless/intel/iwlwifi/mei/net.o: In function `iwl_mei_tx_copy_to_csme':
> net.c:(.text+0xd0): undefined reference to `ieee80211_hdrlen'
> 
> Make IWLMEI depends on CFG80211 to fix this.
> 

It seems has been fixed, Pls igbore this.

> Fixes: 2da4366f9e2c ("iwlwifi: mei: add the driver to allow cooperation with CSME")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 85e704283755..8c003cd29ab7 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -137,7 +137,7 @@ endif
>  
>  config IWLMEI
>  	tristate "Intel Management Engine communication over WLAN"
> -	depends on INTEL_MEI
> +	depends on INTEL_MEI && CFG80211
>  	depends on PM
>  	help
>  	  Enables the iwlmei kernel module.
>