| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Mar 2022 09:55:44 +0800
From: kernel test robot <lkp@...el.com>
To: Oliver Hartkopp <socketcan@...tkopp.net>,
linux-can@...r.kernel.org, netdev@...r.kernel.org
Cc: kbuild-all@...ts.01.org, Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH net-next] net: remove noblock parameter from
skb_recv_datagram()
Hi Oliver,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/Oliver-Hartkopp/net-remove-noblock-parameter-from-skb_recv_datagram/20220319-044459
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git e89600ebeeb14d18c0b062837a84196f72542830
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220319/202203190905.sxFKRU10-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/31180f21a45948092a6c4be3400fd87517ea4eb4
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oliver-Hartkopp/net-remove-noblock-parameter-from-skb_recv_datagram/20220319-044459
git checkout 31180f21a45948092a6c4be3400fd87517ea4eb4
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
In file included from net/mctp/route.c:1405:
net/mctp/test/route-test.c: In function 'mctp_test_route_input_sk_keys':
>> net/mctp/test/route-test.c:585:47: warning: passing argument 3 of 'skb_recv_datagram' makes pointer from integer without a cast [-Wint-conversion]
585 | skb2 = skb_recv_datagram(sock->sk, 0, 1, &rc);
| ^
| |
| int
In file included from include/net/net_namespace.h:40,
from include/linux/netdevice.h:38,
from include/uapi/linux/mctp.h:14,
from net/mctp/route.c:15:
include/linux/skbuff.h:3839:77: note: expected 'int *' but argument is of type 'int'
3839 | struct sk_buff *skb_recv_datagram(struct sock *sk, unsigned int flags, int *err);
| ~~~~~^~~
In file included from net/mctp/route.c:1405:
>> net/mctp/test/route-test.c:585:16: error: too many arguments to function 'skb_recv_datagram'
585 | skb2 = skb_recv_datagram(sock->sk, 0, 1, &rc);
| ^~~~~~~~~~~~~~~~~
In file included from include/net/net_namespace.h:40,
from include/linux/netdevice.h:38,
from include/uapi/linux/mctp.h:14,
from net/mctp/route.c:15:
include/linux/skbuff.h:3839:17: note: declared here
3839 | struct sk_buff *skb_recv_datagram(struct sock *sk, unsigned int flags, int *err);
| ^~~~~~~~~~~~~~~~~
vim +/skb_recv_datagram +585 net/mctp/test/route-test.c
c5755214623dd7 Jeremy Kerr 2022-02-09 534
c5755214623dd7 Jeremy Kerr 2022-02-09 535 /* test packet rx in the presence of various key configurations */
c5755214623dd7 Jeremy Kerr 2022-02-09 536 static void mctp_test_route_input_sk_keys(struct kunit *test)
c5755214623dd7 Jeremy Kerr 2022-02-09 537 {
c5755214623dd7 Jeremy Kerr 2022-02-09 538 const struct mctp_route_input_sk_keys_test *params;
c5755214623dd7 Jeremy Kerr 2022-02-09 539 struct mctp_test_route *rt;
c5755214623dd7 Jeremy Kerr 2022-02-09 540 struct sk_buff *skb, *skb2;
c5755214623dd7 Jeremy Kerr 2022-02-09 541 struct mctp_test_dev *dev;
c5755214623dd7 Jeremy Kerr 2022-02-09 542 struct mctp_sk_key *key;
c5755214623dd7 Jeremy Kerr 2022-02-09 543 struct netns_mctp *mns;
c5755214623dd7 Jeremy Kerr 2022-02-09 544 struct mctp_sock *msk;
c5755214623dd7 Jeremy Kerr 2022-02-09 545 struct socket *sock;
c5755214623dd7 Jeremy Kerr 2022-02-09 546 unsigned long flags;
c5755214623dd7 Jeremy Kerr 2022-02-09 547 int rc;
c5755214623dd7 Jeremy Kerr 2022-02-09 548 u8 c;
c5755214623dd7 Jeremy Kerr 2022-02-09 549
c5755214623dd7 Jeremy Kerr 2022-02-09 550 params = test->param_value;
c5755214623dd7 Jeremy Kerr 2022-02-09 551
c5755214623dd7 Jeremy Kerr 2022-02-09 552 dev = mctp_test_create_dev();
c5755214623dd7 Jeremy Kerr 2022-02-09 553 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, dev);
c5755214623dd7 Jeremy Kerr 2022-02-09 554
c5755214623dd7 Jeremy Kerr 2022-02-09 555 rt = mctp_test_create_route(&init_net, dev->mdev, 8, 68);
c5755214623dd7 Jeremy Kerr 2022-02-09 556 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, rt);
c5755214623dd7 Jeremy Kerr 2022-02-09 557
c5755214623dd7 Jeremy Kerr 2022-02-09 558 rc = sock_create_kern(&init_net, AF_MCTP, SOCK_DGRAM, 0, &sock);
c5755214623dd7 Jeremy Kerr 2022-02-09 559 KUNIT_ASSERT_EQ(test, rc, 0);
c5755214623dd7 Jeremy Kerr 2022-02-09 560
c5755214623dd7 Jeremy Kerr 2022-02-09 561 msk = container_of(sock->sk, struct mctp_sock, sk);
c5755214623dd7 Jeremy Kerr 2022-02-09 562 mns = &sock_net(sock->sk)->mctp;
c5755214623dd7 Jeremy Kerr 2022-02-09 563
c5755214623dd7 Jeremy Kerr 2022-02-09 564 /* set the incoming tag according to test params */
c5755214623dd7 Jeremy Kerr 2022-02-09 565 key = mctp_key_alloc(msk, params->key_local_addr, params->key_peer_addr,
c5755214623dd7 Jeremy Kerr 2022-02-09 566 params->key_tag, GFP_KERNEL);
c5755214623dd7 Jeremy Kerr 2022-02-09 567
c5755214623dd7 Jeremy Kerr 2022-02-09 568 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, key);
c5755214623dd7 Jeremy Kerr 2022-02-09 569
c5755214623dd7 Jeremy Kerr 2022-02-09 570 spin_lock_irqsave(&mns->keys_lock, flags);
c5755214623dd7 Jeremy Kerr 2022-02-09 571 mctp_reserve_tag(&init_net, key, msk);
c5755214623dd7 Jeremy Kerr 2022-02-09 572 spin_unlock_irqrestore(&mns->keys_lock, flags);
c5755214623dd7 Jeremy Kerr 2022-02-09 573
c5755214623dd7 Jeremy Kerr 2022-02-09 574 /* create packet and route */
c5755214623dd7 Jeremy Kerr 2022-02-09 575 c = 0;
c5755214623dd7 Jeremy Kerr 2022-02-09 576 skb = mctp_test_create_skb_data(¶ms->hdr, &c);
c5755214623dd7 Jeremy Kerr 2022-02-09 577 KUNIT_ASSERT_NOT_ERR_OR_NULL(test, skb);
c5755214623dd7 Jeremy Kerr 2022-02-09 578
c5755214623dd7 Jeremy Kerr 2022-02-09 579 skb->dev = dev->ndev;
c5755214623dd7 Jeremy Kerr 2022-02-09 580 __mctp_cb(skb);
c5755214623dd7 Jeremy Kerr 2022-02-09 581
c5755214623dd7 Jeremy Kerr 2022-02-09 582 rc = mctp_route_input(&rt->rt, skb);
c5755214623dd7 Jeremy Kerr 2022-02-09 583
c5755214623dd7 Jeremy Kerr 2022-02-09 584 /* (potentially) receive message */
c5755214623dd7 Jeremy Kerr 2022-02-09 @585 skb2 = skb_recv_datagram(sock->sk, 0, 1, &rc);
c5755214623dd7 Jeremy Kerr 2022-02-09 586
c5755214623dd7 Jeremy Kerr 2022-02-09 587 if (params->deliver)
c5755214623dd7 Jeremy Kerr 2022-02-09 588 KUNIT_EXPECT_NOT_ERR_OR_NULL(test, skb2);
c5755214623dd7 Jeremy Kerr 2022-02-09 589 else
c5755214623dd7 Jeremy Kerr 2022-02-09 590 KUNIT_EXPECT_PTR_EQ(test, skb2, NULL);
c5755214623dd7 Jeremy Kerr 2022-02-09 591
c5755214623dd7 Jeremy Kerr 2022-02-09 592 if (skb2)
c5755214623dd7 Jeremy Kerr 2022-02-09 593 skb_free_datagram(sock->sk, skb2);
c5755214623dd7 Jeremy Kerr 2022-02-09 594
c5755214623dd7 Jeremy Kerr 2022-02-09 595 mctp_key_unref(key);
c5755214623dd7 Jeremy Kerr 2022-02-09 596 __mctp_route_test_fini(test, dev, rt, sock);
c5755214623dd7 Jeremy Kerr 2022-02-09 597 }
c5755214623dd7 Jeremy Kerr 2022-02-09 598
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists