netdev - Re: [PATCH net-next v3 3/3] net: mdio: mscc-miim: add lan966x internal phy reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjUg01ysbonU7L/p@lunn.ch>
Date:   Sat, 19 Mar 2022 01:16:19 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Walle <michael@...le.cc>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH net-next v3 3/3] net: mdio: mscc-miim: add lan966x
 internal phy reset support

On Fri, Mar 18, 2022 at 09:13:24PM +0100, Michael Walle wrote:
> The LAN966x has two internal PHYs which are in reset by default. The
> driver already supported the internal PHYs of the SparX-5. Now add
> support for the LAN966x, too. Add a new compatible to distinguish them.
> 
> The LAN966x has additional control bits in this register, thus convert
> the regmap_write() to regmap_update_bits() to leave the remaining bits
> untouched. This doesn't change anything for the SparX-5 SoC, because
> there, the register consists only of reset bits.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew