netdev - Re: Clarification on user configurable parameters implementation in PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YjX3u7FvPCaVmsmp@lunn.ch>
Date:   Sat, 19 Mar 2022 16:33:15 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Parthiban.Veerasooran@...rochip.com
Cc:     netdev@...r.kernel.org, Jan.Huber@...rochip.com,
        Thorsten.Kummermehr@...rochip.com
Subject: Re: Clarification on user configurable parameters implementation in
 PHY driver

On Fri, Mar 18, 2022 at 12:30:47PM +0000, Parthiban.Veerasooran@...rochip.com wrote:
> Hi All,
> 
> Microchip LAN8670 is a high-performance 10BASE-T1S single-pair Ethernet 
> PHY transceiver for 10 Mbit/s half-duplex networking over a single pair 
> of conductors. The LAN8670 is designed for use in high-reliability cost 
> sensitive industrial, back plane, and building automation 
> sensor/actuator applications.
> 
> Physical Layer Collision Avoidance (PLCA) is one of the features in this 
> PHY which allows for high bandwidth utilization by avoiding collisions 
> on the physical layer and burst mode for transmission of multiple 
> packets for high packet rate latency-sensitive applications. This PLCA 
> feature uses the following user configurable parameters to be configured 
> through PHY driver.
> 
>      1. PLCA node id
>      2. PLCA node count
>      3. PLCA transmit opportunity time
>      4. PLCA max burst count
>      5. PLCA max burst time
>      6. PLCA enable/disable

Hi Parthiban

I just had a quick read of 802.3cg.

As far as i see, it does not define the registers used to control
PLCA. So i guess each vendor will define there own registers in the
vendor section of clause 45? This also means there will not be a
shared implementation in linux, so the API you define needs to go all
the way down into the PHY driver.

What is defined are the management objects. Table 30-11, PLCA
capabilities defines:

aPLCAAdminState ATTRIBUTE GET
aPLCAStatus ATTRIBUTE GET
aPLCABurstTimer ATTRIBUTE GET-SET
aPLCALocalNodeID ATTRIBUTE GET-SET
aPLCAMaxBurstCount ATTRIBUTE GET-SET
aPLCANodeCount ATTRIBUTE GET-SET
aPLCATransmitOpportunityTimer ATTRIBUTE GET-SET

This is basically what you listed above. 

So i suggest you define a netlink API around these, as part of the
Ethtool API. You can reference the standard when defining the API, so
making it clear what the netlink attributes mean, what unit they use
etc.

	Andrew