lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Mar 2022 21:27:52 +0800 From: Menglong Dong <menglong8.dong@...il.com> To: David Ahern <dsahern@...nel.org> Cc: Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...hat.com>, xeb@...l.ru, David Miller <davem@...emloft.net>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Menglong Dong <imagedong@...cent.com>, Eric Dumazet <edumazet@...gle.com>, Martin Lau <kafai@...com>, Talal Ahmad <talalahmad@...gle.com>, Kees Cook <keescook@...omium.org>, Alexander Lobakin <alobakin@...me>, Hao Peng <flyingpeng@...cent.com>, Mengen Sun <mengensun@...cent.com>, dongli.zhang@...cle.com, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Biao Jiang <benbjiang@...cent.com> Subject: Re: [PATCH net-next v3 3/3] net: icmp: add reasons of the skb drops to icmp protocol On Sat, Mar 19, 2022 at 6:33 AM David Ahern <dsahern@...nel.org> wrote: > > On 3/18/22 1:26 AM, Menglong Dong wrote: > > Yeah, PTYPE seems not suitable. I mean that replace SKB_DROP_REASON_PTYPE_ABSENT > > that is used in __netif_receive_skb_core() with L3_PROTO, which means no L3 > > protocol handler (or other device handler) is not found for the > > packet. This seems more > > friendly and not code based. > > > >>> And use SKB_DROP_REASON_L4_PROTO for the L4 protocol problem, > >>> such as GRE version not supported, ICMP type not supported, etc. > > Is this L4_PROTO followed by anyone? > > how about just a generic > SKB_DROP_REASON_UNHANDLED_PROTO /* protocol not implemented > * or not supported > */ > > in place of current PTYPE_ABSENT (so a rename to remove a Linux code > reference), and then use it for no L3 protocol handler, no L4 protocol > handler, version extensions etc. The instruction pointer to symbol gives > the context of the unsupported protocol. Yeah, I think it's a good idea :) Thanks! Menglong Dong
Powered by blists - more mailing lists