lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Mar 2022 01:49:28 +0100 From: Andrew Lunn <andrew@...n.ch> To: Prasanna Vengateshan <prasanna.vengateshan@...rochip.com> Cc: netdev@...r.kernel.org, olteanv@...il.com, robh+dt@...nel.org, UNGLinuxDriver@...rochip.com, woojung.huh@...rochip.com, hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org, vivien.didelot@...il.com, f.fainelli@...il.com, devicetree@...r.kernel.org, Rob Herring <robh@...nel.org> Subject: Re: [PATCH v9 net-next 03/11] dt-bindings: net: dsa: dt bindings for microchip lan937x > +examples: > + port@6 { > + reg = <6>; > + label = "lan5"; > + phy-mode = "internal"; > + phy-handle = <&t1phy4>; > + }; > + port@7 { > + reg = <7>; > + label = "lan3"; > + phy-mode = "internal"; > + phy-handle = <&t1phy5>; > + }; > + }; > + > + mdio { .. > + t1phy4: ethernet-phy@6{ > + reg = <0x6>; > + }; > + t1phy5: ethernet-phy@7{ > + reg = <0x7>; > + }; I know it is only an example, but the numbering is a little odd here. Port 6, which is named lan5 using t1phy4 at address 6? I would be more likely to use t1phy6 instead of t1phy4. And t1phy7 instead of t1phy5. Andrew
Powered by blists - more mailing lists