netdev - Re: [PATCH v3 1/2] bpf: Adjust BPF stack helper functions to accommodate skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164782981040.13314.15450443324560487136.git-patchwork-notify@kernel.org>
Date:   Mon, 21 Mar 2022 02:30:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org, acme@...nel.org,
        peterz@...radead.org, eugene.loh@...cle.com, haoluo@...gle.com
Subject: Re: [PATCH v3 1/2] bpf: Adjust BPF stack helper functions to accommodate
 skip > 0

Hello:

This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Mon, 14 Mar 2022 11:20:41 -0700 you wrote:
> Let's say that the caller has storage for num_elem stack frames.  Then,
> the BPF stack helper functions walk the stack for only num_elem frames.
> This means that if skip > 0, one keeps only 'num_elem - skip' frames.
> 
> This is because it sets init_nr in the perf_callchain_entry to the end
> of the buffer to save num_elem entries only.  I believe it was because
> the perf callchain code unwound the stack frames until it reached the
> global max size (sysctl_perf_event_max_stack).
> 
> [...]

Here is the summary with links:
  - [v3,1/2] bpf: Adjust BPF stack helper functions to accommodate skip > 0
    https://git.kernel.org/bpf/bpf-next/c/ee2a098851bf
  - [v3,2/2] bpf/selftests: Test skipping stacktrace
    https://git.kernel.org/bpf/bpf-next/c/e1cc1f39981b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html