netdev - Re: [PATCH net-next] net: Revert the softirq will run annotation in ____napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9r=NNaA1v55dHxy0Szsqp4PbbSDGUaOeKYtjyNXhGN7_Q@mail.gmail.com>
Date:   Mon, 21 Mar 2022 10:27:50 -0600
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Jakub Kicinski <kuba@...nel.org>, Netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH net-next] net: Revert the softirq will run annotation in ____napi_schedule().

Hi Sebastian,

On Mon, Mar 21, 2022 at 3:22 AM Sebastian Andrzej Siewior
<bigeasy@...utronix.de> wrote:
>
> The lockdep annotation lockdep_assert_softirq_will_run() expects that
> either hard or soft interrupts are disabled because both guaranty that
> the "raised" soft-interrupts will be processed once the context is left.
>
> This triggers in flush_smp_call_function_from_idle() but it this case it
> explicitly calls do_softirq() in case of pending softirqs.
>
> Revert the "softirq will run" annotation in ____napi_schedule() and move
> the check back to __netif_rx() as it was. Keep the IRQ-off assert in
> ____napi_schedule() because this is always required.
>
> Fixes: fbd9a2ceba5c7 ("net: Add lockdep asserts to ____napi_schedule().")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

I can confirm that this fixes the WireGuard splat, so:

Reviewed-by: Jason A. Donenfeld <Jason@...c4.com>

Jason