netdev - Re: [PATCH v9 net-next 09/11] net: dsa: microchip: add support for port mirror operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <661489ea4ba5646d695d55242808f1fb4ae35cfb.camel@microchip.com>
Date:   Tue, 22 Mar 2022 01:52:59 +0530
From:   Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     <andrew@...n.ch>, <netdev@...r.kernel.org>, <robh+dt@...nel.org>,
        <UNGLinuxDriver@...rochip.com>, <woojung.huh@...rochip.com>,
        <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-kernel@...r.kernel.org>, <vivien.didelot@...il.com>,
        <f.fainelli@...il.com>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v9 net-next 09/11] net: dsa: microchip: add support for
 port mirror operations

On Fri, 2022-03-18 at 13:00 +0200, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Fri, Mar 18, 2022 at 02:25:38PM +0530, Prasanna Vengateshan wrote:
> > Added support for port_mirror_add() and port_mirror_del operations
> > 
> > Sniffing is limited to one port & alert the user if any new
> > sniffing port is selected
> > 
> > Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
> > Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> > Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> > ---
> >  drivers/net/dsa/microchip/lan937x_main.c | 84 ++++++++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> > 
> > diff --git a/drivers/net/dsa/microchip/lan937x_main.c
> > b/drivers/net/dsa/microchip/lan937x_main.c
> > index c54aba6a05b5..5a57a2ce8992 100644
> > --- a/drivers/net/dsa/microchip/lan937x_main.c
> > +++ b/drivers/net/dsa/microchip/lan937x_main.c
> > @@ -98,6 +98,88 @@ static void lan937x_port_stp_state_set(struct dsa_switch
> > *ds, int port,
> >       ksz_update_port_member(dev, port);
> >  }
> > 
> > +static int lan937x_port_mirror_add(struct dsa_switch *ds, int port,
> > +                                struct dsa_mall_mirror_tc_entry *mirror,
> > +                                bool ingress)
> 
> This function gained a new extack argument yesterday => your patch
> doesn't compile. Maybe you could even use the extack to propagate the
> "existing sniffer port" error.
> 
> 

Sure, will use the extack for existing errors.

Prasanna V