netdev - Re: pull-request: bpf-next 2022-03-21

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Mar 2022 16:11:19 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     David Miller <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: pull-request: bpf-next 2022-03-21

On Mon, Mar 21, 2022 at 4:02 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Mon, Mar 21, 2022 at 3:46 PM Alexei Starovoitov
> <alexei.starovoitov@...il.com> wrote:
> >
> > The following pull-request contains BPF updates for your *net-next* tree.
>
> No
>
> This is the tree that contains bad architecture code that was NAK'ed
> by both x86 and arm64 people respectively.

I missed the nacks.

Did you look at the code?
In particular:
https://lore.kernel.org/bpf/164735286243.1084943.7477055110527046644.stgit@devnote2/

it's a copy paste of arch/x86/kernel/kprobes/core.c

How is it "bad architecture code" ?

> In particular, I think it's this part:
>
> > Masami Hiramatsu (11):
> >       fprobe: Add ftrace based probe APIs
> >       rethook: Add a generic return hook
> >       rethook: x86: Add rethook x86 implementation
> >       arm64: rethook: Add arm64 rethook implementation
> >       powerpc: Add rethook support
> >       ARM: rethook: Add rethook arm implementation
> >       fprobe: Add exit_handler support
> >       fprobe: Add sample program for fprobe
> >       fprobe: Introduce FPROBE_FL_KPROBE_SHARED flag for fprobe
> >       docs: fprobe: Add fprobe description to ftrace-use.rst
> >       fprobe: Add a selftest for fprobe
>
> That was added very late to the linux-next tree, and that causes build
> warnings because of interactions with other changes.

To be fair Masami's set got to v12 revision and was ready
before Peter's endbr set.
If I didn't miss any email the only known issue
is missing endbr annotation.