netdev - Re: Comment about unstable DSA devicetree binding in marvell.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN9Fmiu83wbnKmbY8wBwdkhbmH37W_Ly10ZYyMaTST3nX4H-Mw@mail.gmail.com>
Date:   Tue, 22 Mar 2022 22:07:59 +0100
From:   Andreas Svensson <andreas93.svensson@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, vivien.didelot@...il.com
Subject: Re: Comment about unstable DSA devicetree binding in marvell.txt

On Mon, Mar 21, 2022 at 6:17 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Mon, Mar 21, 2022 at 06:03:59PM +0100, Andreas Svensson wrote:
> > Hi,
> >
> > I'm looking at using mv88e6xxx-mdio-external for the external MDIO
> > bus to communicate with a PHY.
> >
> > I couldn't help but notice the comment about the devicetree binding
> > being unstable in Documentation/devicetree/bindings/net/dsa/marvell.txt:
> >
> > "WARNING: This binding is currently unstable. Do not program it into a
> > FLASH never to be changed again. Once this binding is stable, this
> > warning will be removed."
> >
> > Any update on this, is marvell.txt still considered unstable?

Thanks for the fast reply Andrew.

> I personally would never write it to FLASH never to be changed
> again. I would always load the DT blob from disk, a version which
> matches the kernel. DT blobs do contain bugs and they need to be
> fixed.

Totally agree.

> The marvell binding has not changed for a long time, so in practice
> you can consider it stable. But just because it is stable does not
> mean DT blobs are bug free.

This is my understanding as well. I have not found any issues so far
using mv88e6xxx-mdio-external which is marvell binding specific.

Thanks for the clarification about the comment!

Best Regards,
Andreas