netdev - Re: [PATCH net] net: dsa: fix panic on shutdown if multi-chip tree failed to probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Mar 2022 05:40:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, f.fainelli@...il.com,
        andrew@...n.ch, vivien.didelot@...il.com, olteanv@...il.com,
        davem@...emloft.net, kuba@...nel.org
Subject: Re: [PATCH net] net: dsa: fix panic on shutdown if multi-chip tree failed
 to probe

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 18 Mar 2022 21:54:43 +0200 you wrote:
> DSA probing is atypical because a tree of devices must probe all at
> once, so out of N switches which call dsa_tree_setup_routing_table()
> during probe, for (N - 1) of them, "complete" will return false and they
> will exit probing early. The Nth switch will set up the whole tree on
> their behalf.
> 
> The implication is that for (N - 1) switches, the driver binds to the
> device successfully, without doing anything. When the driver is bound,
> the ->shutdown() method may run. But if the Nth switch has failed to
> initialize the tree, there is nothing to do for the (N - 1) driver
> instances, since the slave devices have not been created, etc. Moreover,
> dsa_switch_shutdown() expects that the calling @ds has been in fact
> initialized, so it jumps at dereferencing the various data structures,
> which is incorrect.
> 
> [...]

Here is the summary with links:
  - [net] net: dsa: fix panic on shutdown if multi-chip tree failed to probe
    https://git.kernel.org/netdev/net/c/8fd36358ce82

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html