netdev - Re: [PATCH net-next v2] net: remove noblock parameter from skb_recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d550eea-21ae-c495-6936-1747b9619304@hartkopp.net>
Date:   Tue, 22 Mar 2022 09:11:48 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     linux-can@...r.kernel.org, netdev@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v2] net: remove noblock parameter from
 skb_recv_datagram()



On 21.03.22 22:56, Jakub Kicinski wrote:
> On Sat, 19 Mar 2022 10:41:38 +0100 Oliver Hartkopp wrote:
>> skb_recv_datagram() has two parameters 'flags' and 'noblock' that are
>> merged inside skb_recv_datagram() by 'flags | (noblock ? MSG_DONTWAIT : 0)'
>>
>> As 'flags' may contain MSG_DONTWAIT as value most callers split the 'flags'
>> into 'flags' and 'noblock' with finally obsolete bit operations like this:
>>
>> skb_recv_datagram(sk, flags & ~MSG_DONTWAIT, flags & MSG_DONTWAIT, &rc);
>>
>> And this is not even done consistently with the 'flags' parameter.
>>
>> This patch removes the obsolete and costly splitting into two parameters
>> and only performs bit operations when really needed on the caller side.
>>
>> One missing conversion thankfully reported by kernel test robot. I missed
>> to enable kunit tests to build the mctp code.
> 
> net/vmw_vsock/vmci_transport.c: In function ‘vmci_transport_dgram_dequeue’:
> net/vmw_vsock/vmci_transport.c:1735:13: warning: unused variable ‘noblock’ [-Wunused-variable]
>   1735 |         int noblock;
>        |             ^~~~~~~

Sorry. Double checked that really all touched files are now built on my 
machine.

(Except in af_iucv.c which depends on S390 - but double checked the 
changes 4 times).

v3 is already posted:
https://lore.kernel.org/netdev/20220322080317.54887-1-socketcan@hartkopp.net/T/#u

Best regards,
Oliver