lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Mar 2022 12:13:31 +0200 From: Ido Schimmel <idosch@...sch.org> To: Vladimir Oltean <olteanv@...il.com> Cc: Jianbo Liu <jianbol@...dia.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-rdma@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, davem@...emloft.net, kuba@...nel.org, rajur@...lsio.com, claudiu.manoil@....com, sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com, hkelam@...vell.com, saeedm@...dia.com, leon@...nel.org, idosch@...dia.com, petrm@...dia.com, alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com, simon.horman@...igine.com, jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us, baowen.zheng@...igine.com, louis.peens@...ronome.com, peng.zhang@...igine.com, oss-drivers@...igine.com, roid@...dia.com Subject: Re: [PATCH net-next v3 1/2] net: flow_offload: add tc police action parameters On Thu, Mar 17, 2022 at 09:37:22PM +0200, Ido Schimmel wrote: > On Thu, Mar 17, 2022 at 08:52:49PM +0200, Vladimir Oltean wrote: > > I'd just like the 'reclassify' action to be propagated in some reasonable > > way to flow offload, considering that at the moment the error is quite cryptic. > > OK, will check next week. Might be best to simply propagate extack to > offload_act_setup() and return a meaningful message in > tcf_police_offload_act_setup(). There are a bunch of other actions whose > callback simply returns '-EOPNOTSUPP' that can benefit from it. # tc filter add dev dummy0 ingress protocol ip flower skip_sw ip_proto icmp action police rate 100Mbit burst 10000 Error: act_police: Offload not supported when conform/exceed action is "reclassify". We have an error talking to the kernel Available here: https://github.com/idosch/linux/commits/tc_extack I plan to submit the patches after net-next reopens.
Powered by blists - more mailing lists