lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Mar 2022 10:26:15 -0700 From: Joanne Koong <joannelkoong@...il.com> To: Yuntao Wang <ytcoode@...il.com> Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, netdev@...r.kernel.org, bpf <bpf@...r.kernel.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH bpf-next] bpf: Remove redundant assignment to smap->map.value_size On Wed, Mar 23, 2022 at 2:21 AM Yuntao Wang <ytcoode@...il.com> wrote: > > The attr->value_size is already assigned to smap->map.value_size > in bpf_map_init_from_attr(), there is no need to do it again in > stack_map_alloc() > > Signed-off-by: Yuntao Wang <ytcoode@...il.com> LGTM. Acked-by: Joanne Koong <joannelkoong@...il.com> > --- > kernel/bpf/stackmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c > index 34725bfa1e97..6131b4a19572 100644 > --- a/kernel/bpf/stackmap.c > +++ b/kernel/bpf/stackmap.c > @@ -106,7 +106,6 @@ static struct bpf_map *stack_map_alloc(union bpf_attr *attr) > return ERR_PTR(-ENOMEM); > > bpf_map_init_from_attr(&smap->map, attr); > - smap->map.value_size = value_size; > smap->n_buckets = n_buckets; > > err = get_callchain_buffers(sysctl_perf_event_max_stack); > -- > 2.35.0.rc2 >
Powered by blists - more mailing lists