lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Mar 2022 18:36:23 +0100 From: Stefano Garzarella <sgarzare@...hat.com> To: netdev@...r.kernel.org Cc: Jakub Kicinski <kuba@...nel.org>, "Michael S. Tsirkin" <mst@...hat.com>, Asias He <asias@...hat.com>, Arseny Krasnov <arseny.krasnov@...persky.com>, Stefan Hajnoczi <stefanha@...hat.com>, Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org, Stefano Garzarella <sgarzare@...hat.com>, virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org, "David S. Miller" <davem@...emloft.net> Subject: [PATCH net v3 1/3] vsock/virtio: initialize vdev->priv before using VQs When we fill VQs with empty buffers and kick the host, it may send an interrupt. `vdev->priv` must be initialized before this since it is used in the virtqueue callbacks. Fixes: 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock") Suggested-by: Michael S. Tsirkin <mst@...hat.com> Signed-off-by: Stefano Garzarella <sgarzare@...hat.com> --- net/vmw_vsock/virtio_transport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 5afc194a58bb..3e5513934c9f 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -622,6 +622,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev) INIT_WORK(&vsock->event_work, virtio_transport_event_work); INIT_WORK(&vsock->send_pkt_work, virtio_transport_send_pkt_work); + vdev->priv = vsock; + mutex_lock(&vsock->tx_lock); vsock->tx_run = true; mutex_unlock(&vsock->tx_lock); @@ -639,7 +641,6 @@ static int virtio_vsock_probe(struct virtio_device *vdev) if (virtio_has_feature(vdev, VIRTIO_VSOCK_F_SEQPACKET)) vsock->seqpacket_allow = true; - vdev->priv = vsock; rcu_assign_pointer(the_virtio_vsock, vsock); mutex_unlock(&the_virtio_vsock_mutex); -- 2.35.1
Powered by blists - more mailing lists