lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Mar 2022 06:25:43 -0700 From: Eric Dumazet <edumazet@...gle.com> To: Jianguo Wu <wujianguo106@....com> Cc: Menglong Dong <menglong8.dong@...il.com>, David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>, netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] tcp: consume packet after do time wait process On Wed, Mar 23, 2022 at 6:05 AM Jianguo Wu <wujianguo106@....com> wrote: > > From: Jianguo Wu <wujianguo@...natelecom.cn> > > Using consume_skb() instead of kfree_skb_reason() after do normally > time wait process to be drop monitor friendly. > > Signed-off-by: Jianguo Wu <wujianguo@...natelecom.cn> > --- > 1) net-next is closed. 2) This seems pretty much random to me, we definitely reach this point with packets that are dropped. These are classified as drops. You know, TCP can handle reordered packets, spurious retransmits, and stuff like that, we do not want to hide this, otherwise we would have used consume_skb() for all packets. After all, TCP handles all incoming packets 'normally'. If you really care, I suggest you change (when net-next reopens in two weeks) the @reason to more precisely describe what is happening.
Powered by blists - more mailing lists