netdev - Re: [PATCH net-next v2 4/4] net: hns3: support skb's frag page recycling based on page pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yjyz2DIcXiyf7/pL@myrica>
Date:   Thu, 24 Mar 2022 18:09:28 +0000
From:   Jean-Philippe Brucker <jean-philippe@...aro.org>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     linuxarm@...neuler.org, ilias.apalodimas@...aro.org,
        salil.mehta@...wei.com, netdev@...r.kernel.org,
        moyufeng@...wei.com, alexanderduyck@...com, brouer@...hat.com,
        kuba@...nel.org
Subject: Re: [PATCH net-next v2 4/4] net: hns3: support skb's frag page
 recycling based on page pool

Hi,

Sorry for the delay, I had to focus on other issues.

On Mon, Feb 07, 2022 at 10:54:40AM +0800, Yunsheng Lin wrote:
> When there are more than two steps for the freeing side, the only case I know
> about the skb cloning and expanding case, which is fixed by the below commit:
> 2cc3aeb5eccc (skbuff: Fix a potential race while recycling page_pool packets)
> 
> Maybe there are other case we missed?

Yes it's something similar, I found the problem in skb_try_coalesce().
I sent a possible fix, we can continue the discussion there:

https://lore.kernel.org/netdev/20220324172913.26293-1-jean-philippe@linaro.org/

Thanks,
Jean