netdev - Re: [net-next v2] net: core: use shared sysctl macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMDZJNURyrodNAOHYfhTz4Pi+VJJvDBeFCj3w+ZJSk3YSn+juQ@mail.gmail.com>
Date:   Thu, 24 Mar 2022 20:35:04 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        Simon Horman <horms@...ge.net.au>,
        Julian Anastasov <ja@....bg>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Lorenz Bauer <lmb@...udflare.com>,
        Akhmat Karakotov <hmukos@...dex-team.ru>
Subject: Re: [net-next v2] net: core: use shared sysctl macro

On Thu, Mar 24, 2022 at 5:18 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> Hello,
>
> On Wed, 2022-03-23 at 09:53 +0800, xiangxia.m.yue@...il.com wrote:
> > From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> >
> > This patch introdues the SYSCTL_THREE, and replace the
> > two, three and long_one to SYSCTL_XXX accordingly.
> >
> >  KUnit:
> >  [23:03:58] ================ sysctl_test (10 subtests) =================
> >  [23:03:58] [PASSED] sysctl_test_api_dointvec_null_tbl_data
> >  [23:03:58] [PASSED] sysctl_test_api_dointvec_table_maxlen_unset
> >  [23:03:58] [PASSED] sysctl_test_api_dointvec_table_len_is_zero
> >  [23:03:58] [PASSED] sysctl_test_api_dointvec_table_read_but_position_set
> >  [23:03:58] [PASSED] sysctl_test_dointvec_read_happy_single_positive
> >  [23:03:58] [PASSED] sysctl_test_dointvec_read_happy_single_negative
> >  [23:03:58] [PASSED] sysctl_test_dointvec_write_happy_single_positive
> >  [23:03:58] [PASSED] sysctl_test_dointvec_write_happy_single_negative
> >  [23:03:58] [PASSED] sysctl_test_api_dointvec_write_single_less_int_min
> >  [23:03:58] [PASSED] sysctl_test_api_dointvec_write_single_greater_int_max
> >  [23:03:58] =================== [PASSED] sysctl_test ===================
> >
> >  ./run_kselftest.sh -c sysctl
> >  ...
> >  # Running test: sysctl_test_0006 - run #49
> >  # Checking bitmap handler... ok
> >  # Wed Mar 16 14:58:41 UTC 2022
> >  # Running test: sysctl_test_0007 - run #0
> >  # Boot param test only possible sysctl_test is built-in, not module:
> >  # CONFIG_TEST_SYSCTL=m
> >  ok 1 selftests: sysctl: sysctl.sh
> >
> > Cc: Luis Chamberlain <mcgrof@...nel.org>
> > Cc: Kees Cook <keescook@...omium.org>
> > Cc: Iurii Zaikin <yzaikin@...gle.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> > Cc: David Ahern <dsahern@...nel.org>
> > Cc: Simon Horman <horms@...ge.net.au>
> > Cc: Julian Anastasov <ja@....bg>
> > Cc: Pablo Neira Ayuso <pablo@...filter.org>
> > Cc: Jozsef Kadlecsik <kadlec@...filter.org>
> > Cc: Florian Westphal <fw@...len.de>
> > Cc: Dmitry Vyukov <dvyukov@...gle.com>
> > Cc: Alexei Starovoitov <ast@...nel.org>
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Cc: Marc Kleine-Budde <mkl@...gutronix.de>
> > Cc: Lorenz Bauer <lmb@...udflare.com>
> > Cc: Akhmat Karakotov <hmukos@...dex-team.ru>
> > Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> > ---
> > v2: add KUnit and selftests in commit msg
> > ---
> >  fs/proc/proc_sysctl.c          |  2 +-
> >  include/linux/sysctl.h         | 13 +++++++------
> >  net/core/sysctl_net_core.c     | 14 +++++---------
> >  net/ipv4/sysctl_net_ipv4.c     | 16 ++++++----------
> >  net/ipv6/sysctl_net_ipv6.c     |  6 ++----
> >  net/netfilter/ipvs/ip_vs_ctl.c |  4 +---
> >  6 files changed, 22 insertions(+), 33 deletions(-)
>
> Currently we are in the merge window and net-next is accepting only
> fixes. Please repost this after net-next re-open, thanks!
Ok, thanks
> Paolo
>


-- 
Best regards, Tonghao