netdev - Re: [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yjx4O/nOwriKKoNj@localhost>
Date:   Thu, 24 Mar 2022 14:55:07 +0100
From:   Miroslav Lichvar <mlichvar@...hat.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     Gerhard Engleder <gerhard@...leder-embedded.com>,
        yangbo.lu@....com, davem@...emloft.net, kuba@...nel.org,
        vinicius.gomes@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp

On Thu, Mar 24, 2022 at 06:49:34AM -0700, Richard Cochran wrote:
> On Tue, Mar 22, 2022 at 10:07:18PM +0100, Gerhard Engleder wrote:
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -578,6 +578,9 @@ enum {
> >  	/* device driver is going to provide hardware time stamp */
> >  	SKBTX_IN_PROGRESS = 1 << 2,
> >  
> > +	/* generate hardware time stamp based on cycles if supported */
> > +	SKBTX_HW_TSTAMP_USE_CYCLES = 1 << 3,
> 
> Bit 4 used, but 3 was unused... interesting!

It seems the bit 3 and 5 were removed in commit 06b4feb37e64
("net: group skb_shinfo zerocopy related bits together.").

-- 
Miroslav Lichvar