netdev - Re: [PATCH v5 net 3/4] dt-bindings: net: add pcs-handle attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yj4Wl0zmDtnbxgDb@lunn.ch>
Date:   Fri, 25 Mar 2022 20:23:03 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Andy Chiu <andy.chiu@...ive.com>
Cc:     radhey.shyam.pandey@...inx.com, robert.hancock@...ian.com,
        michal.simek@...inx.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, robh+dt@...nel.org, linux@...linux.org.uk,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        robh@...nel.org, Greentime Hu <greentime.hu@...ive.com>
Subject: Re: [PATCH v5 net 3/4] dt-bindings: net: add pcs-handle attribute

> + - pcs-handle: 	  Phandle to the internal PCS/PMA PHY in SGMII or 1000Base-X
> +		  modes, where "pcs-handle" should be preferably used to point
> +		  to the PCS/PMA PHY, and "phy-handle" should point to an
> +		  external PHY if exists.

Since this is a new property, you don't have any backwards
compatibility to worry about, don't use 'preferably'. It should point
to the PCS/PCA PHY and anything else is wrong for this new property.

   Andrew