lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Mar 2022 19:03:43 -0700 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Masami Hiramatsu <mhiramat@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, X86 ML <x86@...nel.org>, Jiri Olsa <jolsa@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii.nakryiko@...il.com>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...omium.org>, Steven Rostedt <rostedt@...dmis.org>, "Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>, "David S . Miller" <davem@...emloft.net> Subject: Re: [PATCH v13 bpf-next 1/1] rethook: x86: Add rethook x86 implementation On Wed, Mar 23, 2022 at 4:41 AM Masami Hiramatsu <mhiramat@...nel.org> wrote: > > On Wed, 23 Mar 2022 09:05:26 +0100 > Peter Zijlstra <peterz@...radead.org> wrote: > > > On Wed, Mar 23, 2022 at 11:34:59AM +0900, Masami Hiramatsu wrote: > > > Add rethook for x86 implementation. Most of the code has been copied from > > > kretprobes on x86. > > > > Right; as said, I'm really unhappy with growing a carbon copy of this > > stuff instead of sharing. Can we *please* keep it a single instance? > > OK, then let me update the kprobe side too. > > > Them being basically indentical, it should be trivial to have > > CONFIG_KPROBE_ON_RETHOOK (or somesuch) and just share this. > > Yes, ideally it should use CONFIG_HAVE_RETHOOK since the rethook arch port > must be a copy of the kretprobe implementation. But for safety, I think > having CONFIG_KPROBE_ON_RETHOOK is a good idea until replacing all kretprobe > implementations. Masami, you're respinning this patch to combine arch_rethook_trampoline and __kretprobe_trampoline right?
Powered by blists - more mailing lists