lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Mar 2022 17:42:46 -0600 From: Shuah Khan <skhan@...uxfoundation.org> To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net Cc: pabeni@...hat.com, netdev@...r.kernel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org, Linux Kernel Functional Testing <lkft@...aro.org>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH net] selftests: tls: skip cmsg_to_pipe tests with TLS=n On 3/25/22 5:27 PM, Jakub Kicinski wrote: > These are negative tests, testing TLS code rejects certain > operations. They won't pass without TLS enabled, pure TCP > accepts those operations. > > Reported-by: Linux Kernel Functional Testing <lkft@...aro.org> > Fixes: d87d67fd61ef ("selftests: tls: test splicing cmsgs") > Signed-off-by: Jakub Kicinski <kuba@...nel.org> > --- > tools/testing/selftests/net/tls.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c > index 6e468e0f42f7..5d70b04c482c 100644 > --- a/tools/testing/selftests/net/tls.c > +++ b/tools/testing/selftests/net/tls.c > @@ -683,6 +683,9 @@ TEST_F(tls, splice_cmsg_to_pipe) > char buf[10]; > int p[2]; > > + if (self->notls) > + SKIP(return, "no TLS support"); > + > ASSERT_GE(pipe(p), 0); > EXPECT_EQ(tls_send_cmsg(self->fd, 100, test_str, send_len, 0), 10); > EXPECT_EQ(splice(self->cfd, NULL, p[1], NULL, send_len, 0), -1); > @@ -703,6 +706,9 @@ TEST_F(tls, splice_dec_cmsg_to_pipe) > char buf[10]; > int p[2]; > > + if (self->notls) > + SKIP(return, "no TLS support"); > + > ASSERT_GE(pipe(p), 0); > EXPECT_EQ(tls_send_cmsg(self->fd, 100, test_str, send_len, 0), 10); > EXPECT_EQ(recv(self->cfd, buf, send_len, 0), -1); > Looks good to me. Thanks for the fix. Reviewed-by: Shuah Khan <skhan@...uxfoundation.org> thanks, -- Shuah
Powered by blists - more mailing lists