lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 25 Mar 2022 10:25:14 +0000
From:   "Penigalapati, Sandeep" <>
To:     "Lobakin, Alexandr" <>,
        "" <>
CC:     "Szapar-Mudlaw, Martyna" <>,
        "" <>,
        "" <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,
        "David S. Miller" <>
Subject: RE: [Intel-wired-lan] [PATCH v4 net-next 3/5] ice: switch: use a
 struct to pass packet template params

>-----Original Message-----
>From: Intel-wired-lan <> On Behalf Of
>Alexander Lobakin
>Sent: Monday, March 21, 2022 4:30 PM
>Cc: Szapar-Mudlaw, Martyna <>;
>;; Jakub Kicinski
><>; Paolo Abeni <>; David S. Miller
>Subject: [Intel-wired-lan] [PATCH v4 net-next 3/5] ice: switch: use a struct to
>pass packet template params
>ice_find_dummy_packet() contains a lot of boilerplate code and a nice room
>for copy-paste mistakes.
>Instead of passing 3 separate pointers back and forth to get packet template
>(dummy) params, directly return a structure containing them. Then, use a
>macro to compose compound literals and avoid code duplication on return
>Now, dummy packet type/name is needed only once to return a full correct
>triple pkt-pkt_len-offsets, and those are all one-liners.
>dummy_ipv4_gtpu_ipv4_packet_offsets is just moved around and renamed
>(as well as dummy_ipv6_gtp_packet_offsets) with no function changes.
>Signed-off-by: Alexander Lobakin <>
>Reviewed-by: Michal Swiatkowski <>
>Tested-by: Marcin Szycik <>
> drivers/net/ethernet/intel/ice/ice_switch.c | 268 +++++++-------------
> 1 file changed, 94 insertions(+), 174 deletions(-)
Tested-by: Sandeep Penigalapati <>

Powered by blists - more mailing lists