lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Mar 2022 13:53:37 +0100 From: Ivan Vecera <ivecera@...hat.com> To: Marcin Szycik <marcin.szycik@...ux.intel.com> Cc: netdev@...r.kernel.org, poros@...hat.com, mschmidt@...hat.com, Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Akeem G Abodunrin <akeem.g.abodunrin@...el.com>, Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>, "moderated list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net] ice: Fix broken IFF_ALLMULTI handling On Wed, 23 Mar 2022 21:05:20 +0100 Marcin Szycik <marcin.szycik@...ux.intel.com> wrote: > > @@ -352,29 +359,15 @@ static int ice_vsi_sync_fltr(struct ice_vsi *vsi) > > /* check for changes in promiscuous modes */ > > if (changed_flags & IFF_ALLMULTI) { > > if (vsi->current_netdev_flags & IFF_ALLMULTI) { > > - if (vsi->num_vlan > 1) > > - promisc_m = ICE_MCAST_VLAN_PROMISC_BITS; > > - else > > - promisc_m = ICE_MCAST_PROMISC_BITS; > > Because `ice_{set,clear}_promisc()` are now always called with the same second argument (ICE_MCAST_PROMISC_BITS), wouldn't it be better to remove the arg and instead call `ice_fltr_{clear,set}_{vlan,vsi}_vsi_promisc()` with either ICE_MCAST_VLAN_PROMISC_BITS or ICE_MCAST_PROMISC_BITS inside the function? Because ice_{set,clear}_promisc() then could be used only for set mcast prosmisc mode so I modified them only to automatically insert ICE_PROMISC_VLAN_RX & ICE_PROMISC_VLAN_TX based on vsi->num_vlan value. Anyway I will fix some objections from Jacob and send v2. Thanks, Ivan
Powered by blists - more mailing lists