netdev - Re: [PATCH net] selftests: test_vxlan_under

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b134fd1b-38da-381a-1d69-2d98a53a54eb@gmail.com>
Date:   Fri, 25 Mar 2022 08:08:53 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        abauvin@...leway.com, akherbouche@...leway.com, mlxsw@...dia.com
Subject: Re: [PATCH net] selftests: test_vxlan_under_vrf: Fix broken test case

On 3/24/22 2:05 PM, Ido Schimmel wrote:
> The purpose of the last test case is to test VXLAN encapsulation and
> decapsulation when the underlay lookup takes place in a non-default VRF.
> This is achieved by enslaving the physical device of the tunnel to a
> VRF.
> 
> The binding of the VXLAN UDP socket to the VRF happens when the VXLAN
> device itself is opened, not when its physical device is opened. This
> was also mentioned in the cited commit ("tests that moving the underlay
> from a VRF to another works when down/up the VXLAN interface"), but the
> test did something else.
> 
> Fix it by reopening the VXLAN device instead of its physical device.
> 
> Before:
> 
>  # ./test_vxlan_under_vrf.sh
>  Checking HV connectivity                                           [ OK ]
>  Check VM connectivity through VXLAN (underlay in the default VRF)  [ OK ]
>  Check VM connectivity through VXLAN (underlay in a VRF)            [FAIL]
> 
> After:
> 
>  # ./test_vxlan_under_vrf.sh
>  Checking HV connectivity                                           [ OK ]
>  Check VM connectivity through VXLAN (underlay in the default VRF)  [ OK ]
>  Check VM connectivity through VXLAN (underlay in a VRF)            [ OK ]
> 
> Fixes: 03f1c26b1c56 ("test/net: Add script for VXLAN underlay in a VRF")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  tools/testing/selftests/net/test_vxlan_under_vrf.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 



Reviewed-by: David Ahern <dsahern@...nel.org>