lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Mar 2022 10:04:54 +0300 From: Leon Romanovsky <leon@...nel.org> To: Benjamin Stürz <benni@...erz.xyz> Cc: andrew@...n.ch, sebastian.hesselbarth@...il.com, gregory.clement@...tlin.com, linux@...linux.org.uk, linux@...tec.co.uk, krzk@...nel.org, alim.akhtar@...sung.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com, robert.moore@...el.com, rafael.j.wysocki@...el.com, lenb@...nel.org, 3chas3@...il.com, laforge@...monks.org, arnd@...db.de, gregkh@...uxfoundation.org, mchehab@...nel.org, tony.luck@...el.com, james.morse@....com, rric@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl, mike.marciniszyn@...nelisnetworks.com, dennis.dalessandro@...nelisnetworks.com, jgg@...pe.ca, pali@...nel.org, dmitry.torokhov@...il.com, isdn@...ux-pingi.de, benh@...nel.crashing.org, fbarrat@...ux.ibm.com, ajd@...ux.ibm.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, nico@...xnic.net, loic.poulain@...aro.org, kvalo@...nel.org, pkshih@...ltek.com, bhelgaas@...gle.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-ia64@...r.kernel.org, linux-acpi@...r.kernel.org, devel@...ica.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-edac@...r.kernel.org, linux-gpio@...r.kernel.org, linux-rdma@...r.kernel.org, linux-input@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-media@...r.kernel.org, wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org, linux-pci@...r.kernel.org Subject: Re: [PATCH 11/22] rdmavt: Replace comments with C99 initializers On Sat, Mar 26, 2022 at 05:58:58PM +0100, Benjamin Stürz wrote: > This replaces comments with C99's designated > initializers because the kernel supports them now. > > Signed-off-by: Benjamin Stürz <benni@...erz.xyz> > --- > drivers/infiniband/sw/rdmavt/rc.c | 62 +++++++++++++++---------------- > 1 file changed, 31 insertions(+), 31 deletions(-) > > diff --git a/drivers/infiniband/sw/rdmavt/rc.c b/drivers/infiniband/sw/rdmavt/rc.c > index 4e5d4a27633c..121b8a23ac07 100644 > --- a/drivers/infiniband/sw/rdmavt/rc.c > +++ b/drivers/infiniband/sw/rdmavt/rc.c > @@ -10,37 +10,37 @@ > * Convert the AETH credit code into the number of credits. > */ > static const u16 credit_table[31] = { > - 0, /* 0 */ > - 1, /* 1 */ > - 2, /* 2 */ > - 3, /* 3 */ > - 4, /* 4 */ > - 6, /* 5 */ > - 8, /* 6 */ > - 12, /* 7 */ > - 16, /* 8 */ > - 24, /* 9 */ > - 32, /* A */ > - 48, /* B */ > - 64, /* C */ > - 96, /* D */ > - 128, /* E */ > - 192, /* F */ > - 256, /* 10 */ > - 384, /* 11 */ > - 512, /* 12 */ > - 768, /* 13 */ > - 1024, /* 14 */ > - 1536, /* 15 */ > - 2048, /* 16 */ > - 3072, /* 17 */ > - 4096, /* 18 */ > - 6144, /* 19 */ > - 8192, /* 1A */ > - 12288, /* 1B */ > - 16384, /* 1C */ > - 24576, /* 1D */ > - 32768 /* 1E */ > + [0x00] = 0, > + [0x01] = 1, > + [0x02] = 2, > + [0x03] = 3, > + [0x04] = 4, > + [0x05] = 6, > + [0x06] = 8, > + [0x07] = 12, > + [0x08] = 16, > + [0x09] = 24, > + [0x0A] = 32, > + [0x0B] = 48, > + [0x0C] = 64, > + [0x0D] = 96, > + [0x0E] = 128, > + [0x0F] = 192, > + [0x10] = 256, > + [0x11] = 384, > + [0x12] = 512, > + [0x13] = 768, > + [0x14] = 1024, > + [0x15] = 1536, > + [0x16] = 2048, > + [0x17] = 3072, > + [0x18] = 4096, > + [0x19] = 6144, > + [0x1A] = 8192, > + [0x1B] = 12288, > + [0x1C] = 16384, > + [0x1D] = 24576, > + [0x1E] = 32768 > }; I have hard time to see any value in this commit, why is this change needed? Thanks > > /** > -- > 2.35.1 > >
Powered by blists - more mailing lists