lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Mar 2022 19:51:39 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Vladimir Oltean <olteanv@...il.com>, Xiaomeng Tong <xiam0nd.tong@...il.com> Cc: andrew@...n.ch, vivien.didelot@...il.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH] dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator On 3/27/2022 11:58 AM, Vladimir Oltean wrote: > On Sun, Mar 27, 2022 at 01:55:47PM +0800, Xiaomeng Tong wrote: >> The bug is here: >> return rule; >> >> The list iterator value 'rule' will *always* be set and non-NULL >> by list_for_each_entry(), so it is incorrect to assume that the >> iterator value will be NULL if the list is empty or no element >> is found. >> >> To fix the bug, return 'rule' when found, otherwise return NULL. >> >> Cc: stable@...r.kernel.org >> Fixes: ae7a5aff783c7 ("net: dsa: bcm_sf2: Keep copy of inserted rules") >> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@...il.com> >> --- > > The change looks correct, but from a process standpoint for next time > (a) you should have copied Florian, the driver's maintainer (which I did now) > who appears on the top of the list in the output of ./get_maintainer.pl > (b) networking bugfixes that apply to the "net" tree shouldn't need > stable@...r.kernel.org copied, instead just target the patch against > the https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git > tree and mark the subject prefix as "[PATCH net]". > > Reviewed-by: Vladimir Oltean <olteanv@...il.com> If you could please resubmit with the subject being: net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator and add Vladimir's and my tag below: Reviewed-by: Florian Fainelli <f.fainelli@...il.com> That would be great! Thanks -- Florian
Powered by blists - more mailing lists